Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrades Plex Media Server to 1.41.0.8992 #232

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

pustovalov
Copy link
Contributor

@pustovalov pustovalov commented Sep 8, 2024

Proposed Changes

https://forums.plex.tv/t/plex-media-server/30447/642

Summary by CodeRabbit

  • New Features
    • Upgraded to the latest version of Plex Media Server, which may include new features, bug fixes, and security enhancements.

Copy link

coderabbitai bot commented Sep 8, 2024

Walkthrough

The pull request updates the Dockerfile for the Plex Media Server by changing the version of the software being downloaded. The URL for the Debian package has been modified from version 1.40.4.8679-424562606 to 1.41.0.8992-8463ad060, indicating an upgrade to a newer version. The overall structure and control flow of the Dockerfile remain unchanged.

Changes

File Change Summary
plex/Dockerfile Updated the download URL for the Plex Media Server from version 1.40.4.8679-424562606 to 1.41.0.8992-8463ad060.

Possibly related PRs

Poem

🐰 In the garden where updates bloom,
A new Plex version chases gloom.
With each byte and bit, we cheer,
For smoother streams, we hold dear.
Hop along, let’s celebrate,
A media server that’s first-rate! 🎉


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e572af0 and 930df28.

Files selected for processing (1)
  • plex/Dockerfile (1 hunks)
Additional comments not posted (1)
plex/Dockerfile (1)

25-25: LGTM! Version update looks good, but PR title needs adjustment.

The update to Plex Media Server version 1.41.0.8992-8463ad060 is correct and aligns with the PR objective of upgrading the server. However, there's a discrepancy between the PR title, which mentions version 1.40.5.8921, and the actual version being installed (1.41.0.8992-8463ad060).

Could you please update the PR title to reflect the correct version (1.41.0.8992-8463ad060) being installed? This will ensure consistency between the PR description and the actual changes.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 99161dd and e572af0.

Files selected for processing (1)
  • plex/Dockerfile (1 hunks)
Additional comments not posted (2)
plex/Dockerfile (2)

Line range hint 1-49: Overall Dockerfile Review: Best Practices and Optimizations.

The Dockerfile is well-structured and follows best practices for Docker builds, including the use of labels to provide metadata, and cleaning up after package installations to reduce the image size. No further optimizations are necessary at this time.


25-25: Verify the updated URL for correctness and accessibility.

The change in the URL to download the newer version of Plex Media Server is noted and appears correct. However, it's crucial to ensure that the URL is accessible and points to a valid Debian package.

Run the following script to verify the URL's accessibility:

Verification successful

To accurately verify the accessibility of the Plex Media Server URL, we need to specify a valid architecture value for the ${ARCH} variable. Let's re-run the test with a common architecture like amd64.


URL is accessible and correctly formatted.

The updated URL for downloading the Plex Media Server Debian package is accessible and correctly formatted when using the amd64 architecture. This confirms that the change in the Dockerfile is valid and functional. No further action is needed regarding this URL update.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the accessibility of the new Plex Media Server URL.

# Test: Attempt to download the Debian package. Expect: Successful download without errors.
curl -o /dev/null -sfI "https://downloads.plex.tv/plex-media-server-new/1.40.5.8921-836b34c27/debian/plexmediaserver_1.40.5.8921-836b34c27_${ARCH}.deb"
if [ $? -eq 0 ]; then
    echo "URL is accessible."
else
    echo "URL is not accessible."
fi

Length of output: 218


Script:

#!/bin/bash
# Description: Verify the accessibility of the new Plex Media Server URL with a specific architecture.

ARCH="amd64"
URL="https://downloads.plex.tv/plex-media-server-new/1.40.5.8921-836b34c27/debian/plexmediaserver_1.40.5.8921-836b34c27_${ARCH}.deb"

# Test: Attempt to download the Debian package. Expect: Successful download without errors.
curl -o /dev/null -sfI "$URL"
if [ $? -eq 0 ]; then
    echo "URL is accessible."
else
    echo "URL is not accessible."
fi

Length of output: 358

@frenck frenck added the dependencies Upgrade or downgrade of project dependencies. label Sep 23, 2024
plex/Dockerfile Outdated Show resolved Hide resolved
@frenck frenck changed the title ⬆️ Upgrades Plex Media Server to 1.40.5.8921 ⬆️ Upgrades Plex Media Server to 1.41.0.8992 Sep 23, 2024
@frenck frenck added the minor This PR causes a minor version bump in the version number. label Sep 23, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pustovalov 👍

../Frenck

@frenck frenck merged commit 68915b7 into hassio-addons:main Sep 23, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies. minor This PR causes a minor version bump in the version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants